Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KBM]Set extended flag for media keys #25576

Merged

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

Keyboard manager is sending scancodes for media keys which are being interpreted in some applications as other keys, as is exemplified in the issue this PR closes ( #25463 ).
This is caused by us sending the scancode without prefixing it with e0 as expected for extended keys (which in key events means adding the KEYEVENTF_EXTENDEDKEY flag to the event).
This PR adds the Windows Multimedia keys to the list of keys we're sending the extended flag. Source used to select the keys is: https://tigerheli.mameworld.info/encoder/scancodesset2.htm

PR Checklist

Validation Steps Performed

As mentioned in the issue, used https://en.key-test.ru/ to verify that, without the fix, mapping a key to Volume Down was registering the key C as well.
With the fix, using a key mapped to volume down no longer registers C.

@stefansjfw stefansjfw merged commit 3164e03 into microsoft:main Apr 21, 2023
BLM16 pushed a commit to BLM16/PowerToys that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants