[MWB]Fix crash when trying to read null settings #27682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
After #27442 , there's a bug where both Mouse Without Borders and opening the Mouse Without Borders settings page will crash after the first reload due to trying to read null settings.
Detailed Description of the Pull Request / Additional comments
Add a null check around the Settings, since they might not be there from migration if the user never ran a version before .72.
Validation Steps Performed
1 - Clear %localappdata%\Microsoft\PowerToys
2 - Enable MWB, generate a key
3 - Restart PowerToys as admin
4 - Enable "Service Mode". Verify that MWB is started as a service successfully
5 - Go to another settings page, then try to enter MWB page again. Settings doesn't crash anymore.