[FancyZones] UI testing #29453
[FancyZones] UI testing #29453
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Tests work for me as well. Good work!
I've added some code comments for changes I think we might need.
Some more general comments:
So, the Utils/IOUtils.cs from FancyZonesEditorCommon seems to be duplicated on FancyZonesEditor Utils/IOHelper? Is there a reason?
Lots of code seems to have been copied like enums (e.g.: LayoutType), but there's no comment to mention what they're mirroring from the original code. This will make it harder to maintain. Can you please add those comments?
doc/devdocs/modules/fancyzones.md
Outdated
|
|
||
| #### [`trace.cpp`](/src/modules/fancyzones/lib/trace.cpp) | ||
| TODO | ||
| - Download and run Windows Application Driver installer from https://github.com/Microsoft/WinAppDriver/releases |
There was a problem hiding this comment.
I updated the doc and specified the version.
| searchFolder: '$(Build.ArtifactStagingDirectory)' | ||
| vstestLocationMethod: 'location' # otherwise fails to find vstest.console.exe | ||
| #vstestLocation: '$(Agent.ToolsDirectory)\VsTest\**\${{ parameters.platform }}\tools\net462\Common7\IDE\Extensions\TestPlatform' | ||
| vstestLocation: '$(Agent.ToolsDirectory)\VsTest\17.10.0-preview-24080-01\x64\tools\net462\Common7\IDE\Extensions\TestPlatform' |
There was a problem hiding this comment.
Won't this fail when visual studio updates in CI? It's got a hard coded version.
| @@ -15,7 +15,8 @@ Param( | |||
| $referencedFileVersionsPerDll = @{} | |||
| $totalFailures = 0 | |||
|
|
|||
| Get-ChildItem $targetDir -Recurse -Filter *.deps.json | ForEach-Object { | |||
| Get-ChildItem $targetDir -Recurse -Filter *.deps.json -Exclude UITests-FancyZones* | ForEach-Object { | |||
| # Temporarily exclude FancyZones UI tests because of Appium.WebDriver dependencies | |||
There was a problem hiding this comment.
I suppose these will only get built in the tests folder, so there's no chance of binary collisions, right?
There was a problem hiding this comment.
That's right, the output is in the tests folder.
| <Import Project="..\..\..\Version.props" /> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net7.0-windows</TargetFramework> |
There was a problem hiding this comment.
We're on net8 already on main. This one is lagging behind.
There was a problem hiding this comment.
Thanks for noticing, fixed!
src/modules/fancyzones/UITests-FancyZonesEditor/UITests-FancyZonesEditor.csproj
Fixed
Show fixed
Hide fixed
This comment has been minimized.
This comment has been minimized.
SeraphimaZykova
deleted the
dev/seraphima/tests/29246-fancyzones-tests-initial-step
branch
PR microsoft#29453 removed the `src/tests/win-app-driver` folder, but missed removing the sln file reference to the folders `README.md` file.
PR microsoft#29453 removed the `src/tests/win-app-driver` folder, but missed removing the sln file reference to the folders `README.md` file.
PR #29453 removed the `src/tests/win-app-driver` folder, but missed removing the sln file reference to the folders `README.md` file.
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed