[Settings > PT Run > PluginAdditionalOptions] Fix crash on empty number box

[htcfreek]

Summary of the Pull Request

The settings app crashes when the user clears the number box and presses enter or moves the focus away from it. This happens because the value is not a valid number and converting this to double produces double.NaN. The double.NaN then leads to the app crash.

To fix this we now check the value of the number box against NaN and if the check is true we send a NotifyPropertyChanged() command. This lets the NumberBox reload its binding value and resets the NumberBox to the last valid number input.

We should consider this PR in a HotFix if we need one after releasing v0.81.0!

PR Checklist

• Closes: [Run Plugin] Settings crashes if Numberbox is empty #32738
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

[Jay-o-Way]

"severity high" + "wait for 0.82" ?

[htcfreek]

"severity high" + "wait for 0.82" ?

Issue has "Severity highd".

@jaimecbernardo marked other PRs last week with "wait for 0.82". So I thought the time frame for 0.81 is closed. @jaimecbernardo, is it closed?

[jaimecbernardo]

"severity high" + "wait for 0.82" ?

Issue has "Severity highd".

@jaimecbernardo marked other PRs last week with "wait for 0.82". So I thought the time frame for 0.81 is closed. @jaimecbernardo, is it closed?

We can still get some simpler ones in. This one I think can go in. We're waiting for "Patch Tuesday" tomorrow to receive latest .NET and only after that build the release candidate, so this can still get in.

Help me out understand something: this doesn't affect any current PowerToys Run plugin, right? I don't think we're using this NumberBox one ourselves, or are we? @htcfreek

[htcfreek]

@jaimecbernardo

1. We don't use it in any of our built-in plugins.
2. This has no impacts on any configuration files or plugin code. It only improves the value handling in the PluginOption ViewModel of the PT Run Settings page.
3. It simply resets empty input to the last know valid value.

[jaimecbernardo]

LGTM! Thank you for the contribution!
Thanks for the answers @htcfreek . That's what I thought as well.