Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev][Build] .NET 9 Upgrade #35716

Merged
merged 44 commits into from
Nov 13, 2024
Merged

[Dev][Build] .NET 9 Upgrade #35716

merged 44 commits into from
Nov 13, 2024

Conversation

snickler
Copy link
Collaborator

@snickler snickler commented Nov 2, 2024

Summary of the Pull Request

.NET 9 Upgrade. Requires at least Visual Studio 17.12 to compile.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

The following changes have been made:

  • Update TFMs to net9.0
  • Update .NET Runtime-related NuGet packages to 9.x
  • Add support to CI for manual triggered builds against agents running VS Preview
  • Resolve Analyzer issues:
    • WFO1000: Property 'property' does not configure the code serialization for its property content.
  • New Breaking Analyzers set to warning without error:
    • CA1859: Use concrete types when possible for improved performance
    • CA2263: Prefer generic overload when type is known
    • CA2022: Avoid inexact read with Stream.Read

Validation Steps Performed

@snickler snickler force-pushed the dev/snickler/dotnet9-release branch from c4aca7b to 60d4a0e Compare November 5, 2024 01:58
@htcfreek
Copy link
Collaborator

.Net9 supports title bar customization natively. Might be interesting for Peek.

See https://learn.microsoft.com/de-de/dotnet/maui/whats-new/dotnet-9?view=net-maui-9.0#titlebar-for-windows .

@snickler snickler marked this pull request as ready for review November 13, 2024 11:17
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity checked a build from Dart. All was good.
Code LGTM too!
Great work! Thanks for the contribution!

@jaimecbernardo jaimecbernardo changed the title 🚧 [Dev][Build] .NET 9 Upgrade [Dev][Build] .NET 9 Upgrade Nov 13, 2024
@snickler snickler merged commit 00ee6c1 into main Nov 13, 2024
16 checks passed
@snickler snickler deleted the dev/snickler/dotnet9-release branch November 13, 2024 17:37
mikeclayton added a commit to mikeclayton/PowerToys that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants