Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Drop Down from combo box name as it is redundant #7307

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

mykhailopylyp
Copy link
Contributor

@mykhailopylyp mykhailopylyp commented Oct 15, 2020

Summary of the Pull Request

What is this about?
Remove redundant part from a Combobox name.

PR Checklist

Info on Pull Request

Validation Steps Performed

How does someone test & validate?
Check with the Narrator if combobox in Remap keys/Remap shortcuts windows have correct names that is they should not contain redundant Drop Down. As an alternative Accessibility Insight can be used.
image

@htcfreek
Copy link
Collaborator

@mykhailopylyp
In the issue under expected behaviour is described that also "the header label should be associated with" the combo box. Is this done in another PR?

@mykhailopylyp
Copy link
Contributor Author

@htcfreek
Good point! I did not implement that as when a user navigates to the first control of a cell they get to know that they are in Key or Mapped To column. Let's discuss it in the issue.

@mykhailopylyp mykhailopylyp merged commit 4634c74 into master Oct 16, 2020
@mykhailopylyp mykhailopylyp deleted the redifine-combobox-name branch October 16, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Issues related to accessibility Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants