Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor file retry functionality and update API endpoint #596

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

georearl
Copy link
Contributor

This PR was to remove a redundant retry/resubmit function that was from an initial PR to manage this from the community. This was replaced by the new resubmit and delete function some time back. The PR addresses this, but during dev I discovered another error. When a file was resubmitted, its status was not changing immediately in the document status table. This was because a net new json document was being created for the file. The reason this was happening is because the document key is the encoded full path of the file including the container, 'upload'. On resubmission it was just using the file name, hence another document. I have added the full path and verified it works as expected now

@dayland dayland disabled auto-merge March 28, 2024 13:28
@dayland dayland merged commit e5de59a into vNext-Dev Mar 28, 2024
5 of 6 checks passed
@dayland dayland deleted the geearl/7161-redundant-retry-function branch March 28, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants