Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max sweep delay #47

Merged
merged 3 commits into from
Mar 1, 2016
Merged

Max sweep delay #47

merged 3 commits into from
Mar 1, 2016

Conversation

alexcjohnson
Copy link
Contributor

@AdriaanRol re #44 - this PR adds a max_sweep_delay to argument to StandardParameter, along with the existing sweep_delay argument. If you give both, then we try to wait sweep_delay but don't generate a log warning unless the delay is longer than max_sweep_delay.

I also changed it so negative delays don't compound - that is, if you have one instance of too long a delay, the loop won't attempt to make up the difference in the next iteration, and will not keep adding to the time error.

And for calculating delay times I switched from datetime.now() to time.perf_counter() - which is relative, not absolute, time, but it is much higher resolution.

@AdriaanRol
Copy link
Contributor

Looks good but I am a bit confsed with the log catcher in the utils.helpers. I thought in the end we decided not to catch logging messages or is this only there for testing purposes?

@alexcjohnson
Copy link
Contributor Author

Looks good but I am a bit confsed with the log catcher in the utils.helpers. I thought in the end we decided not to catch logging messages or is this only there for testing purposes?

Right, only for testing purposes. I just put it in there because I needed it across multiple test files, and I could imagine people finding use cases for this down the line - like if you want to do something nice with log messages in the GUI.

@AdriaanRol
Copy link
Contributor

Sounds good 💃

alexcjohnson added a commit that referenced this pull request Mar 1, 2016
@alexcjohnson alexcjohnson merged commit ba22c08 into master Mar 1, 2016
@alexcjohnson alexcjohnson deleted the max-sweep-delay branch March 1, 2016 09:03
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Jun 27, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Jul 7, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Jul 18, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Aug 3, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Aug 3, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Aug 7, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Aug 9, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Aug 10, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Aug 16, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Aug 18, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Aug 22, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Sep 21, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
nataliejpg pushed a commit to nataliejpg/Qcodes that referenced this pull request Oct 11, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Oct 27, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Nov 21, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Nov 23, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants