Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

ApplyWindowed #603

Merged
merged 8 commits into from
Jul 20, 2022
Merged

ApplyWindowed #603

merged 8 commits into from
Jul 20, 2022

Conversation

adrianleh
Copy link
Contributor

Implementation of #602

Applies an operation windowing over input but with const target qubits
@ghost
Copy link

ghost commented Jul 7, 2022

CLA assistant check
All CLA requirements met.

Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments for the main operation, the docs ones can be safely copied to the three other ones. For the sample, I would not copy it over, but rather add a reference from the variants to the first operation so that the example in it can be discovered:

    /// # See Also
    /// - Microsoft.Quantum.Arrays.ApplyWindowed

Standard/src/Arrays/Windows.qs Outdated Show resolved Hide resolved
Standard/src/Arrays/Windows.qs Outdated Show resolved Hide resolved
Standard/src/Arrays/Windows.qs Outdated Show resolved Hide resolved
Standard/src/Arrays/Windows.qs Outdated Show resolved Hide resolved
Standard/src/Arrays/Windows.qs Outdated Show resolved Hide resolved
Copy link
Member

@msoeken msoeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @adrianleh

Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small formatting comment

Standard/src/Arrays/Windows.qs Show resolved Hide resolved
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@msoeken
Copy link
Member

msoeken commented Jul 20, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@msoeken msoeken merged commit 0ac7ac1 into microsoft:main Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants