-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Add German support for recognizers-date-time #2728
Conversation
I see there are some issues here... I will have a look, putting on DRAFT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot more than 8 tests are now failing. What were the main change's you've made?
I'd suggest first making the Python version run, instead of editting the YAML file at the same time. Directly porting the .NET code should lead to all tests passing (please make sure the json schema tests are enabled for Python). I.e., you should not copy the English Python code and adapt it (well, you can do it as a base, but then reference .NET back for the latest flow).
Also, you mentioned you "converted the German Datetime YAML into a python file and attempted to adapt the English config files to the german patterns." I believe in the current version it's being auto-generated, as I see edits in the generator for German, as well as the auto-gen header in the German resources file. Please confirm that the auto generation is running correctly.
@tellarin Afterwards, I made a first change to the order of the yaml, because the autogeneration of the python regexes did not work due to simple patterns being referenced before they were declared in the YAML. Regarding the failing German Thanks for the suggestion about porting the .NET code. It seems my pull request was premature, I am trying to better understand how everything works. Would you suggest I close it for now, or do you mind if I leave it as a draft for a little while? Cheers Brian |
@BrianInGermany feel free to leave it in Draft for as long as you need. You can also use it to ask any questions you may have. |
@BrianInGermany Are you still looking into this? I suggest cleaning the PR, so we can start by merging the basic code skeleton for German and its tests. Then implement and refine sub-type by sub-type. |
Closing this as #2914 has added German Number/Currency/DateTimeV2 close to parity with .NET. |
#2197