Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flag "--allow-privileged" form start-kubelet.ps1 in Kubernetes 1.15 #379

Closed
mrwonkerz opened this issue Jul 9, 2019 · 3 comments · Fixed by #383
Closed

Remove flag "--allow-privileged" form start-kubelet.ps1 in Kubernetes 1.15 #379

mrwonkerz opened this issue Jul 9, 2019 · 3 comments · Fixed by #383

Comments

@mrwonkerz
Copy link

mrwonkerz commented Jul 9, 2019

The start-kubelet.ps1 runs in the an error when using with kubernetes version 1.15
In Kubernetes 1.15 the flag "--allow-privileged" for kubelet is obsolete.

.\start-kubelet.ps1 -NetworkMode Overlay -KubeDnsServiceIP 10.96.0.10 -LogDir C:\k\Logs
Flag --enable-debugging-handlers has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Usage:
  kubelet [flags]
...
F0709 11:25:37.135712    3088 server.go:156] unknown flag: --allow-privileged

The kubelet-Service can not be started because of this.
Removing the flag "--allow-privileged" from the start-kubelet.ps1 script fixes the issue.

$kubeletArgs = @(
    "--hostname-override=$(hostname)"
    "--v=6"
    "--pod-infra-container-image=mcr.microsoft.com/k8s/core/pause:1.0.0"
    "--enable-debugging-handlers"
#   "--allow-privileged=true"
    "--cluster-dns=$KubeDnsServiceIp"
    "--cluster-domain=cluster.local"
    "--kubeconfig=c:\k\config"
    "--hairpin-mode=promiscuous-bridge"
    "--image-pull-progress-deadline=20m"
    "--cgroups-per-qos=false"
    "--log-dir=$LogDir"
    "--logtostderr=false"
    "--enforce-node-allocatable="""
    "--network-plugin=cni"
    "--cni-bin-dir="c:\k\cni""
    "--cni-conf-dir="c:\k\cni\config""
    "--node-ip=$(Get-MgmtIpAddress)"
)
if ($KubeletFeatureGates -ne "")
{
    $kubeletArgs += "--feature-gat
wk8 added a commit to wk8/SDN that referenced this issue Jul 10, 2019
Since that flag got deprecated in version 1.15, and the kubelet won't
start if it's present.

Fixes microsoft#379
@wk8
Copy link
Contributor

wk8 commented Jul 10, 2019

Fixed in #383

wk8 added a commit to wk8/SDN that referenced this issue Jul 10, 2019
Since that flag got deprecated in version 1.15, and the kubelet won't
start if it's present.

Fixes microsoft#379
@mrwonkerz
Copy link
Author

@wk8 I found out that the same problem exists int the register-svc.ps1 script.

Thanks for the fix

@wk8
Copy link
Contributor

wk8 commented Jul 11, 2019

@mrwonkerz : thanks, good catch. Should be fixed by the new commit I've added to my PR (0965379).

madhanrm pushed a commit that referenced this issue Aug 6, 2019
)

* Only using the kubelet flag `allow-privileged` for versions < 1.15

Since that flag got deprecated in version 1.15, and the kubelet won't
start if it's present.

Fixes #379

* Consolidating kubelet flags

Signed-off-by: Jean Rouge <rougej+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants