Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VCPKG_TARGET_TRIPLET enforcement. #101

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Sep 17, 2019

Resolves #97

Checklist:

  • I understand README.md.
  • If this is a feature addition, that feature has been voted into the C++
    Working Draft.
  • Any code files edited have been processed by clang-format.
  • Identifiers in any product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 .
  • Identifiers in test code changes are not _Ugly.
  • Test code includes the correct headers as per the Standard, not just
    what happens to compile.
  • The STL builds and test harnesses have passed (must be manually verified
    by an STL maintainer before CI is online, leave this unchecked for initial
    submission).
  • This change introduces no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate or
    trivially copyable, etc.). If unsure, leave this box unchecked and ask a
    maintainer for help.

Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a very short explanation of the motivation for the change to your commit, beyond linking to the issue? "This was unused." would be sufficient.

@BillyONeal BillyONeal merged commit ee1ede2 into microsoft:master Sep 17, 2019
@BillyONeal BillyONeal deleted the target_triplet branch September 17, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VCPKG_TARGET_TRIPLET not used but required?
4 participants