Cleanup <any> and allow overaligned types #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
`<any>` cleanup: * Prefer variable templates to class templates * Prefer `if constexpr` to tag dispatch * Function pointers may be `noexcept` in C++17 * Remove the layer of "symbolic member name" functions to improve debug codegen * Conventionally use `enable_if_t<conjunction_v<meow, woof>` instead of `enable_if_t<meow::value && woof::value>` * Apply `_NODISCARD` and `noexcept` to internal functions as appropriate * Allow overaligned types, which are properly handled by the `_Big` representation Resolves [DevCom-724444](https://developercommunity.visualstudio.com/content/problem/724444/meow.html).
StephanTLavavej
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<any>cleanup:if constexprto tag dispatchnoexceptin C++17enable_if_t<conjunction_v<meow, woof>>instead ofenable_if_t<meow::value && woof::value>_NODISCARDandnoexceptto internal functions as appropriate_BigrepresentationResolves DevCom-724444.
(This is a replay of Microsoft-internal PR 207713.)
Checklist
If you're unsure about a box, leave it unchecked. A maintainer will help you.
If a box isn't applicable, add an explanation in bold.
For example: (N/A: this is a bugfix, not a feature)
community PRs will be delayed until the test and CI systems are online.
C++ Working Draft.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 .
verified by an STL maintainer before CI is online, leave this unchecked for
initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft as a reference (and any other cited standards).
If they were derived from a project that's already listed in
NOTICE.txt,that's fine, but please mention it. If they were derived from any other
project (including Boost and libc++, which are not yet listed in
NOTICE.txt), you must mention it here, so we can determine whether thelicense is compatible and what else needs to be done.