Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P0767R1 Deprecating is_pod #179

Merged
merged 2 commits into from
Oct 23, 2019

Conversation

crackedmind
Copy link
Contributor

@crackedmind crackedmind commented Oct 17, 2019

Description

Fixes #36
Added deprecation warning about using is_pod and is_pod_v in C++20 mode

Checklist

  • I understand README.md. I also understand that acceptance of
    community PRs will be delayed until the test and CI systems are online.
  • If this is a feature addition, that feature has been voted into the
    C++ Working Draft.
  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 .
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before CI is online, leave this unchecked for
    initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository and
    the C++ Working Draft as a reference (and any other cited standards).
    If they were derived from a project that's already listed in NOTICE.txt,
    that's fine, but please mention it. If they were derived from any other
    project (including Boost and libc++, which are not yet listed in
    NOTICE.txt), you must mention it here, so we can determine whether the
    license is compatible and what else needs to be done.

@crackedmind crackedmind requested a review from a team as a code owner October 17, 2019 14:22
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
@CaseyCarter
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
@crackedmind crackedmind force-pushed the deprecate_pod branch 3 times, most recently from 99796d7 to d640a1c Compare October 18, 2019 13:26
@CaseyCarter
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@CaseyCarter
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephanTLavavej
Copy link
Member

I'm preparing a Microsoft-internal PR for this with associated test changes.

@StephanTLavavej
Copy link
Member

For future reference: Like is_literal_type and is_literal_type_v, this is currently affected by VSO-437892 "C1XX emits a generic warning C4996 "was declared deprecated" for variable templates declared with [[deprecated("MESSAGE")]]" and VSO-480568 "C1XX should warn about usage of deprecated type traits even when they inherit from non-deprecated classes".

@crackedmind
Copy link
Contributor Author

Yeah, i found VSO-480568 while testing this feature and created issue

@CaseyCarter
Copy link
Member

Yeah, i found VSO-480568 while testing this feature and created issue

Thanks for bringing the issue to our attention: I've internally linked up VSO-480568 with DevCom-782069.

@StephanTLavavej
Copy link
Member

Status update: I've sent out that Microsoft-internal PR with tests, so I should be able to merge this tomorrow.

@StephanTLavavej StephanTLavavej merged commit f05c358 into microsoft:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P0767R1 Deprecating is_pod
3 participants