Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document import library #2141

Merged
merged 33 commits into from
Apr 7, 2023
Merged

Document import library #2141

merged 33 commits into from
Apr 7, 2023

Conversation

AlexGuteniev
Copy link
Contributor

Resolve #483

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner August 19, 2021 18:33
@CaseyCarter CaseyCarter added the documentation Related to documentation or comments label Aug 19, 2021
@StephanTLavavej StephanTLavavej self-assigned this Aug 25, 2021
bhardwajs
bhardwajs reviewed Oct 5, 2021
View reviewed changes
docs/import_library.txt Outdated Show resolved Hide resolved
@AlexGuteniev AlexGuteniev mentioned this pull request Oct 25, 2021
Merged
@AlexGuteniev AlexGuteniev mentioned this pull request Feb 5, 2022
Merged
StephanTLavavej
StephanTLavavej reviewed Apr 4, 2023
View reviewed changes
stl/inc/regex Outdated Show resolved Hide resolved
stl/inc/__msvc_system_error_abi.hpp Outdated Show resolved Hide resolved
docs/import_library.txt Outdated Show resolved Hide resolved
stl/src/sharedmutex.cpp Outdated Show resolved Hide resolved
stl/inc/xcharconv_tables.h Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Apr 4, 2023
@StephanTLavavej StephanTLavavej mentioned this pull request Apr 4, 2023
Merged
strega-nil-ms
strega-nil-ms approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all!

@StephanTLavavej StephanTLavavej self-assigned this Apr 7, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 8a652e6 into microsoft:main Apr 7, 2023
@StephanTLavavej
Copy link
Member

Thanks for improving the documentation for this confusing area and upgrading <xcharconv_tables.h>! 📜 😻 ✅

@AlexGuteniev AlexGuteniev deleted the import_lib branch April 7, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@bhardwajs bhardwajs bhardwajs left review comments

@frederick-vs-ja frederick-vs-ja frederick-vs-ja left review comments

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
documentation Related to documentation or comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

STL: We should better tag those files which might end up in import libs
6 participants
@AlexGuteniev @StephanTLavavej @bhardwajs @frederick-vs-ja @strega-nil-ms @CaseyCarter