-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move nlsdownlevel.h into winapinls.cpp (#188) #220
Move nlsdownlevel.h into winapinls.cpp (#188) #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - this is almost [NFC], so it shouldn't require additional test coverage.
(Stephan adds: "NFC" means No Functional Changes.)
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Casey predicted, Azure Pipelines detected that clang-format needs to be run on this file.
By the way, thanks for working on this! Note to self: after this is revised and merged on GitHub, we will need to make a Microsoft-internal change to remove nlsdownlevel.h from "setup authoring" (which installs the file as part of Visual Studio). The setup authoring files that need to be changed are for the entire MSVC toolset, which is why they can't be part of this GitHub repo. |
27779bf
to
af36d45
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I've made those Microsoft-internal changes and I'm running this through our build system. |
Thanks for the improvement, and congratulations on your first commit to the STL! Now that you've made the tables |
Thanks :) I'll keep an eye on #224 |
Description
Checklist
If you're unsure about a box, leave it unchecked. A maintainer will help you.
community PRs will be delayed until the test and CI systems are online.
_Ugly
as perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before CI is online, leave this unchecked for
initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft as a reference (and any other cited standards).
If they were derived from a project that's already listed in NOTICE.txt,
that's fine, but please mention it. If they were derived from any other
project (including Boost and libc++, which are not yet listed in
NOTICE.txt), you must mention it here, so we can determine whether the
license is compatible and what else needs to be done.