-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P1209R0 erase_if(), erase() #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! If you can update this with the code movement and other relatively minor changes requested, we can write some tests and merge this.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines is failing due to clang-format validation. Please run clang-format 9.0.0 before pushing the next round of updates. For the |
I just added them to the end of because I didn't know where else to put it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo test coverage.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks perfect, with one stylistic ordering nitpick. To save time, I'll push a change for that, then work on porting this over to our MSVC-internal repo and writing simple tests (plus changes needed to remove <experimental/xutility>
from the VS installer). We should be able to merge this tomorrow if all goes well.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This passed all of our tests, including libcxx's tests (modulo some truncation warnings in their test code that we'll need to fix in the near future). Thanks again, and congratulations for implementing your first C++20 feature here! |
Description
Resolves #55.
Checklist
If you're unsure about a box, leave it unchecked. A maintainer will help you.
community PRs will be delayed until the test and CI systems are online.
_Ugly
as perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before CI is online, leave this unchecked for
initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft as a reference (and any other cited standards).
If they were derived from a project that's already listed in NOTICE.txt,
that's fine, but please mention it. If they were derived from any other
project (including Boost and libc++, which are not yet listed in
NOTICE.txt), you must mention it here, so we can determine whether the
license is compatible and what else needs to be done.