Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __cpp_lib_concepts (see WG21-P1902). #287

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

StephanTLavavej
Copy link
Member

Description

Update __cpp_lib_concepts (see WG21-P1902).

This feature-test macro is being extensively queried, so we're updating it with high priority ahead of the other feature-test macro changes in this paper.

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository and
    the C++ Working Draft as a reference (and any other cited standards).
    If they were derived from a project that's already listed in NOTICE.txt,
    that's fine, but please mention it. If they were derived from any other
    project (including Boost and libc++, which are not yet listed in
    NOTICE.txt), you must mention it here, so we can determine whether the
    license is compatible and what else needs to be done.

@StephanTLavavej StephanTLavavej requested a review from a team as a code owner November 12, 2019 01:02
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obligatory "needs test coverage" comment.

@StephanTLavavej StephanTLavavej merged commit bfb96b1 into microsoft:master Nov 12, 2019
@StephanTLavavej StephanTLavavej deleted the cpp_lib_concepts branch November 12, 2019 05:25
fengjixuchui added a commit to fengjixuchui/STL that referenced this pull request Nov 12, 2019
Update __cpp_lib_concepts (see WG21-P1902). (microsoft#287)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants