Relocate endian to <bit> #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
CaseyCarter
approved these changes
Nov 16, 2019
There was a problem hiding this comment.
This change looks good. You should know that you're racing @barcharcraz to add <bit>; the loser will have to resolve the merge conflicts. ;)
EDIT: The CI failure is about line endings in <bit>: you have LF endings, and we require CRLF.
Co-Authored-By: Casey Carter <cartec69@gmail.com>
CaseyCarter
approved these changes
Nov 16, 2019
StephanTLavavej
requested changes
Nov 16, 2019
Co-Authored-By: Stephan T. Lavavej <stl@nuwen.net>
StephanTLavavej
approved these changes
Nov 16, 2019
|
my PR is up at #310 The race is on ;D |
BillyONeal
approved these changes
Nov 19, 2019
|
I am porting this to our Microsoft-internal MSVC repo and running tests; when that's successful, I'll merge your PR here, and we'll rebase Charlie's PR accordingly. |
|
Merged for VS 2019 16.5 Preview 2. Thanks again, and congratulations on implementing your first C++20 feature here! |
SuperWig
pushed a commit
to SuperWig/STL
that referenced
this pull request
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #61
Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft (including any cited standards), other WG21 papers
(excluding reference implementations outside of proposed standard wording),
and LWG issues as reference material. If they were derived from a project
that's already listed in NOTICE.txt, that's fine, but please mention it.
If they were derived from any other project (including Boost and libc++,
which are not yet listed in NOTICE.txt), you must mention it here,
so we can determine whether the license is compatible and what else needs
to be done.