Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolset update: VS 2022 17.4 Preview 2 #3104

Merged
merged 4 commits into from
Sep 15, 2022

Conversation

StephanTLavavej
Copy link
Member

  • Updated build compiler to VS 2022 17.4 Preview 2.
  • Updated CMake to 3.24 (now required).
  • Updated Python to 3.10.7.

Contains Patch Tuesday.

@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Sep 14, 2022
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner September 14, 2022 23:57
Copy link
Contributor

@killerswin2 killerswin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the "build guide" to 3.10. Just a suggestion, up to you if you want to due so.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@StephanTLavavej
Copy link
Member Author

@killerswin2 Thanks for noticing that discrepancy. It's currently intentional as the VS Installer still provides only Python 3.9.7, which is why the README says "3.9 or later", and similarly for our requirement:

find_package(Python "3.9" REQUIRED COMPONENTS Interpreter)

We could increase this requirement, which would align with how the PR/CI system runs tests (also myself and probably most contributors/maintainers), but then we could no longer recommend installing Python from VS. I'll check with the other maintainers to see what they want to do.

@StephanTLavavej StephanTLavavej self-assigned this Sep 15, 2022
@StephanTLavavej
Copy link
Member Author

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

README.md Show resolved Hide resolved
@StephanTLavavej StephanTLavavej merged commit b127e68 into microsoft:main Sep 15, 2022
@StephanTLavavej StephanTLavavej deleted the toolset-update-17.4p2 branch September 15, 2022 20:49
CaseyCarter pushed a commit to CaseyCarter/STL that referenced this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants