-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update google-benchmark to 1.7.0 #3151
Conversation
@strega-nil-ms will investigate why the build is failing. |
It looks like there is a bug in google benchmark that means we can't update for now:
Edit: See google/benchmark#1450; there is a workaround. |
I'm not 100% convinced separating out the benchmark build is an improvement. Our main build is a bit of an oddball though. |
@barcharcraz there were multiple problems caused by having google benchmark as part of the main build (like, in google benchmark's build system); splitting it out removed those problems. I would prefer not to if there weren't those issues, but I also don't think creating workarounds is worth making the benchmark part of the main build. |
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks @AtariDreams for updating this dependency and @strega-nil-ms for reworking the build system! ✅ 🚀 🎉 |
Additionally makes benchmarks separate from the STL build, since we keep having problems when google benchmark is built in the STL build.