-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P2165R4: Compatibility Between tuple
, pair
, And tuple-like Objects
#3372
Conversation
Also fix `_Guide_key_t`
tuple
, pair
, And *tuple-like* Objectstuple
, pair
, And tuple-like Objects
Maybe, I am not sure :( Also, skip some LLVM tests due to failing static assertions in new hidden friends
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
LWG issue for the friendship bug with proposed resolution (matching this implementation) https://cplusplus.github.io/LWG/issue3882 (Thanks for pinging me about that!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushing a partial review; should finish tmrw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great; thanks @JMazurkiewicz!
Looks good to me too. I've pushed one last commit to improve the merge with #3483's reformatting, FYI @strega-nil-ms. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
I've pushed a commit to address several issues that I found while mirroring:
|
Thanks again, one more step closer to C++23! 😻 🎉 🚀 |
Closes #2917.