Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement P1690R1 Refining Heterogeneous Lookup For Unordered Containers #341

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

cpplearner
Copy link
Contributor

@cpplearner cpplearner commented Nov 28, 2019

Description

Fixes #338

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

@cpplearner cpplearner requested a review from a team as a code owner November 28, 2019 16:53
@BillyONeal BillyONeal self-assigned this Dec 1, 2019
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! I've fixed our tests to respond to these changes and everything passed.

Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I also checked WG21-N4842 and the feature-test macro value hasn't changed.

@BillyONeal BillyONeal merged commit 1d39dfa into microsoft:master Dec 3, 2019
@BillyONeal
Copy link
Member

@cpplearner Thank you for your contribution!

@cpplearner cpplearner deleted the master branch March 1, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P1690R1 Refining Heterogeneous Lookup For Unordered Containers
4 participants