Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React to internal test improvements #3484

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

CaseyCarter
Copy link
Member

  • Tell the internal test runner to use expected_results.txt instead of skipped_tests.txt as its control file. (The internal runner has learned to translate the expected_results.txt format to what it needs.)
  • Move skips for the two XFAIL: msvc tests from skipped_tests into expected_results. (LIT ignores these, but the internal runner needs them.)
  • Remove main from compile-only tests in std; the internal test runner understands compile-only tests now.

This is a dual of MSVC-PR-453118.

* Tell the internal test runner to use `expected_results.txt` instead of `skipped_tests.txt` as its control file. (The internal runner has learned to translate the `expected_results.txt` format to what it needs.)
* Move skips for the two `XFAIL: msvc` tests from `skipped_tests` into `expected_results`. (LIT ignores these, but the internal runner needs them.)
* Remove `main` from compile-only tests in `std`; the internal test runner understands compile-only tests now.

This is a dual of MSVC-PR-453118.
@CaseyCarter CaseyCarter added the infrastructure Related to repository automation label Feb 20, 2023
@CaseyCarter CaseyCarter requested a review from a team as a code owner February 20, 2023 07:38
JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request Feb 20, 2023
With assumption that we don't need `int main() {} // COMPILE-ONLY` anymore thanks to microsoft#3484
@StephanTLavavej
Copy link
Member

StephanTLavavej on Mar 23, 2020
I am concerned that we now have two lists of skipped tests for libcxx; this seems like it will get desynced easily. Is there some way to rely on a single list, or possibly a main list with a small secondary list of Python-runner-specific skips? Ideally, someone with a libcxx update that passes checks on GitHub should automatically pass on MSVC-internal and vice versa.

😹 😻 📆

@CaseyCarter
Copy link
Member Author

Is there some way to rely on a single list, or possibly a main list with a small secondary list of Python-runner-specific skips?

I had always thought this needed to look like "teach the internal test runner to run LIT", until roughly the 10,000th time I did the "copy from expected_results.txt to skipped_tests.txt, strip std/ prefix, strip any :0 MEOW suffix, and replace / with \" dance and it occurred to me that we could simply have the internal test runner do that. It seems so obvious in hindsight.

@CaseyCarter CaseyCarter merged commit e7f5244 into microsoft:main Feb 21, 2023
@CaseyCarter CaseyCarter deleted the compile-only branch February 21, 2023 18:23
@StephanTLavavej StephanTLavavej mentioned this pull request May 28, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants