Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolset update: VS 2022 17.6 Preview 1 #3490

Merged
merged 6 commits into from
Feb 23, 2023

Conversation

StephanTLavavej
Copy link
Member

  • Updated dependencies.
    • Updated build compiler to VS 2022 17.6 Preview 1 (now required).
    • Updated CMake to 3.25.2 (now required).
  • Removed compiler bug workarounds.
    • MSVC-PR-436582 updated C1XX's __is_aggregate for LWG-3823.
    • We can enable a couple of libcxx tests that were marked as FAILing for MSVC.
  • CMake 3.25.2 fixed CMake-24249, so we can enable the CMP0141 policy.
    • Then, we need to set CMAKE_MSVC_DEBUG_INFORMATION_FORMAT to Embedded. This will pass the correct options to MSVC and MASM, avoiding cl : Command line warning D9025 : overriding '/Zi' with '/Z7'.

StephanTLavavej and others added 6 commits February 21, 2023 11:43
Now that we're enabling CMP0141, we need to set CMAKE_MSVC_DEBUG_INFORMATION_FORMAT to Embedded, which avoids:

```
cl : Command line warning D9025 : overriding '/Zi' with '/Z7'
```
@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Feb 22, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner February 22, 2023 01:22
@StephanTLavavej StephanTLavavej self-assigned this Feb 22, 2023
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit f51e945 into microsoft:main Feb 23, 2023
@StephanTLavavej StephanTLavavej deleted the vs17.6p1 branch February 23, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants