Cleanups: Split type and object definitions #3526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few cases where we prefer to spend extra lines for clarity. (Examples: In modern code we strongly prefer to avoid packing too many side-effects into an expression, we avoid defining multiple variables on a single line, and we usually prefer to avoid elaborate conditional operators.)
One such case is simultaneously defining a type and an object. We prefer to do this separately, because they happen in different "domains". (Only lambdas get to be special!)
We accumulated a few occurrences throughput the codebase, which I tracked down. I consider this convention important enough (and the transformation simple enough) to be worth updating
tests/std
.