Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups: Avoid almost always auto #3530

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Cleanups: Avoid almost always auto #3530

merged 3 commits into from
Mar 7, 2023

Commits on Mar 3, 2023

  1. P2321R2_views_zip: Avoid almost always auto. 

    Name the parameters single_element_container and three_element_container,
as that's relevant to the caller. Then we can rename the local copy to
just `writable`, which avoids wrapping lines.
    @StephanTLavavej
    StephanTLavavej committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    746faf7 View commit details
    Browse the repository at this point in the history

  2. Avoid almost always auto.

    @StephanTLavavej
    StephanTLavavej committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    621ffa8 View commit details
    Browse the repository at this point in the history

  3. __msvc_int128.hpp: Use static_cast instead of almost always auto. 

    MSVC emits a probably-unjustified signed/unsigned warning if we attempt
to directly initialize _Int_max. Since we're intentionally changing the
type from int to size_t, it seems stylistically best to emphasize this
with a static_cast anyways.
    @StephanTLavavej
    StephanTLavavej committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    63379f4 View commit details
    Browse the repository at this point in the history