-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<ranges>
: Test c(begin|end)
members of range factories
#3553
Merged
StephanTLavavej
merged 6 commits into
microsoft:main
from
JMazurkiewicz:const-range-factories
Mar 13, 2023
Merged
<ranges>
: Test c(begin|end)
members of range factories
#3553
StephanTLavavej
merged 6 commits into
microsoft:main
from
JMazurkiewicz:const-range-factories
Mar 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 tasks
JMazurkiewicz
force-pushed
the
const-range-factories
branch
from
March 9, 2023 11:31
cc0b2cd
to
9e9db33
Compare
strega-nil-ms
approved these changes
Mar 9, 2023
StephanTLavavej
approved these changes
Mar 9, 2023
Thanks for extending this test coverage! 😻 I've pushed very minor changes for my favorite issues. FYI @strega-nil-ms as you already approved. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks again! 🕵️ ✅ 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3391.
This PR adds extra tests for
c(begin|end)
members of C++ range factories ([range.factories]):views::empty
,views::single
,views::iota
,views::repeat
,views::istream
.