Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #344. Set _MSVC_STL_UPDATE value to December 2019. #358

Merged
merged 2 commits into from
Dec 7, 2019

Conversation

SasLuca
Copy link
Contributor

@SasLuca SasLuca commented Dec 6, 2019

Description

Fix for #344
Set _MSVC_STL_UPDATE value to December 2019

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

@SasLuca SasLuca requested a review from a team as a code owner December 6, 2019 22:36
…upport overloaded `operator&()`
@msftclas
Copy link

msftclas commented Dec 6, 2019

CLA assistant check
All CLA requirements met.

@CaseyCarter
Copy link
Member

Thanks for the submission!

We'll need you to accept the CLA to merge this (admittedly small) change.

Also, please submit distinct changes as distinct pull requests in the future. It's not truly problematic in this specific case - these two changes are small enough that we can make it work without issue - but with larger changes it would a problem.

@SasLuca
Copy link
Contributor Author

SasLuca commented Dec 6, 2019

I will be more careful in the future. I only realized this after I did it, but I am glad it's ok since it's a small change.

@BillyONeal BillyONeal self-assigned this Dec 6, 2019
@StephanTLavavej StephanTLavavej merged commit ad5b806 into microsoft:master Dec 7, 2019
@StephanTLavavej
Copy link
Member

@BillyONeal ported this to our Microsoft-internal repo and all of our builds and tests passed, so I've merged your PR here. Thanks again for the fixes, and congratulations on your first MSVC STL change! This will appear in VS 2019 16.5 Preview 2.

fengjixuchui added a commit to fengjixuchui/STL that referenced this pull request Dec 7, 2019
Use _STD addressof(_Val), update _MSVC_STL_UPDATE (microsoft#358)
@Neargye Neargye mentioned this pull request Dec 12, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants