Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move _Char_traits_eq and _Char_traits_lt from <xstring> to <regex> #3625

Merged

Conversation

frederick-vs-ja
Copy link
Contributor

As these functors are only used in <regex>. Separated from #3623.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner April 5, 2023 06:49
@StephanTLavavej StephanTLavavej added the throughput Must compile faster label Apr 5, 2023
@StephanTLavavej
Copy link
Member

Thanks, this is an excellent change!

  • Pure code movement, no other changes.
  • The partial specializations are unquestionably safe - while they aren't next to the primary templates, they appear immediately after the _Char_traits_meow types they're being specialized for, so there is zero chance that the primary templates could have been used before the partial specializations are seen.
  • These are internal types, so there is no breaking change impact unless users were being very bad kitties indeed 😼

@barcharcraz
Copy link
Member

Verified identical code (only movement). Looks good.

@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 2df667e into microsoft:main Apr 7, 2023
@StephanTLavavej
Copy link
Member

Thanks again for this small but clean throughput improvement! 🐈 🚀 🎉

@frederick-vs-ja frederick-vs-ja deleted the throughput-regex-xstring branch April 8, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
throughput Must compile faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants