Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuse <xstddef> into <type_traits> #3654

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

<xstddef> is only included by <type_traits> after #3623 and #3633, so perhaps it's time to fuse <xstddef> into <type_traits>.

I'm also changing or eliminating some comments in test files that mention <xstddef>.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner April 14, 2023 16:59
@StephanTLavavej StephanTLavavej added the throughput Must compile faster label Apr 14, 2023
@StephanTLavavej
Copy link
Member

Looks good to me, thanks!

@StephanTLavavej StephanTLavavej self-assigned this Apr 20, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 9bb3566 into microsoft:main Apr 20, 2023
@StephanTLavavej
Copy link
Member

Thanks for simplifying the codebase! ✅ ✨ 🐱

@KrisGeorges
Copy link

KrisGeorges commented Aug 12, 2023

This shouldn't have source-breaking impact unless someone was directly including xstddef.

Yes, there was actually someone out there doing that, believe it or not. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
throughput Must compile faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants