Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #347: <shared_mutex>: Do we still need the _USING_V110_SDK71_ guard? #373

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

StephanTLavavej
Copy link
Member

Description

While we must continue to support msvcp140.dll running on Windows XP,
we don't need to support compiling our headers with the (removed)
v140_xp toolset and its corresponding old Windows SDK. Accordingly,
we can unconditionally define shared_mutex. (This is a C++17 feature,
but it was implemented before Standard modes, so it's not guarded by
_HAS_CXX17.)

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

…DK71_ guard?

While we must continue to support `msvcp140.dll` running on Windows XP,
we don't need to support compiling our headers with the (removed)
`v140_xp` toolset and its corresponding old Windows SDK. Accordingly,
we can unconditionally define `shared_mutex`. (This is a C++17 feature,
but it was implemented before Standard modes, so it's not guarded by
`_HAS_CXX17`.)
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner December 11, 2019 04:34
@StephanTLavavej StephanTLavavej merged commit 1666b7c into microsoft:master Dec 12, 2019
@StephanTLavavej StephanTLavavej deleted the shared_mutex branch December 12, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants