Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #96

Merged
merged 3 commits into from
Sep 18, 2019
Merged

Fix typos #96

merged 3 commits into from
Sep 18, 2019

Conversation

practicalswift
Copy link
Contributor

Description

Fix typos.

Checklist:

  • I understand README.md.
  • If this is a feature addition, that feature has been voted into the C++
    Working Draft.
  • Any code files edited have been processed by clang-format.
  • Identifiers in any product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 .
  • Identifiers in test code changes are not _Ugly.
  • Test code includes the correct headers as per the Standard, not just
    what happens to compile.
  • The STL builds and test harnesses have passed (must be manually verified
    by an STL maintainer before CI is online, leave this unchecked for initial
    submission).
  • This change introduces no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate or
    trivially copyable, etc.). If unsure, leave this box unchecked and ask a
    maintainer for help.

@msftclas
Copy link

msftclas commented Sep 17, 2019

CLA assistant check
All CLA requirements met.

Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some whitespace damage here - and in <memory> and <regex> - that suggests you're not using clang-format 8.0.1. I'll clean it up, but for future reference please use 8.0.1 so we don't have churn in the sources from competing versions of clang-format.

@CaseyCarter
Copy link
Member

@practicalswift, it looks like you haven't yet signed our Contributor License Agreement (CLA). Unfortunately, we cannot accept contributions without the signed CLA.

@StephanTLavavej
Copy link
Member

#103 updates the pull request template to provide proper guidance regarding clang-format version.

@StephanTLavavej StephanTLavavej merged commit 7f65140 into microsoft:master Sep 18, 2019
@StephanTLavavej
Copy link
Member

Thank you! 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants