Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extremely minor duplication #63

Merged
merged 1 commit into from
May 16, 2023
Merged

Remove extremely minor duplication #63

merged 1 commit into from
May 16, 2023

Conversation

zk-Lee
Copy link
Contributor

@zk-Lee zk-Lee commented Apr 13, 2023

I noticed that the next_power_of_two call in the following code is redundant:

let N = (0..sparse_polys.len())
  .map(|i| sparse_polys[i].get_num_nz_entries())
  .max()
  .unwrap()
  .next_power_of_two();

Since next_power_of_two is already being called in the get_num_nz_entries method, it can be safely removed from this code without affecting performance. Therefore, I have made a pull request to remove this redundant call.

Thank you!

@srinathsetty srinathsetty merged commit e0f964c into microsoft:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants