Multiple SQL Nexus fixes (#250, #251, #238, #254)

[PiJoCoder]

1. Allow the ability to minimize Cmd prompt window when Relog.exe imports Performance .BLG files into SQL Nexus

   

2. Allow the ability to import XEL files using local server time, rather than UTC time (default) via ReadTrace

   

3. Fixed "Save my options" functionality in the import window to ensure the import options were really saved. Some of the options weren't saved before even though the GUI shows the boxes are checked.

   

   To test this last fix,

   • select "Save my options"
   • then enable one of the import options (for example minimize Cmd Window (relog.exe) )
   • Do the import.
   • Then close the Import dialog
   • Open it back up
   • Re-import and ensure the option is still working

4. REDO_THREAD_PENDING_WORK wait type is now ignorable type, which means it will not show up in the Bottleneck Analysis report as a bar in the bar chart.

[asavioliMSFT]

REDO_THREAD_PENDING_WORK wait type is now ignorable type, which means it will not show up in the Bottleneck Analysis report as a bar in the bar chart.

Currently I have one nexus loaded where a related wait is the highest one

Current nexus version

Version from the PR. We no longer see the REDO_THREAD_PENDING_WORK, but we still can see PARALLEL_REDO_WORKER_WAIT_WORK. I'm wondering if this one could also be ignored

[PiJoCoder]

Yes, there are many such wait types. Can you file an issue on Github and add this and this other one I sent to Haci the other day QDS_ASYNC_QUEUE be an ignorable wait type? If you can think of others add them to the list. Thanks

…

________________________________ From: Andre Savioli ***@***.***> Sent: Monday, November 13, 2023 5:38:45 AM To: microsoft/SqlNexus ***@***.***> Cc: Joseph Pilov ***@***.***>; Author ***@***.***> Subject: Re: [microsoft/SqlNexus] Multiple SQL Nexus fixes (#250, #251, #238, #254) (PR #259) REDO_THREAD_PENDING_WORK wait type is now ignorable type, which means it will not show up in the Bottleneck Analysis report as a bar in the bar chart. Currently I have one nexus loaded where a related wait is the highest one Current nexus version [image]<https://user-images.githubusercontent.com/49494532/282449422-b3034f73-19a9-43c1-86fa-b4674e27dac0.png> Version from the PR. We no longer see the REDO_THREAD_PENDING_WORK, but we still can see PARALLEL_REDO_WORKER_WAIT_WORK. I'm wondering if this one could also be ignored [image]<https://user-images.githubusercontent.com/49494532/282449366-d5312f8e-6400-449e-ac8d-5e116daf3f74.png> — Reply to this email directly, view it on GitHub<#259 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFTOCHKJ5BZWUJKFUV2ICSTYEIBD7AVCNFSM6AAAAAA56EHTXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBXHE4TGNRWGU>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[asavioliMSFT]

Performed the tests below

• select "Save my options"

• then enable one of the import options (for example minimize Cmd Window (relog.exe) )

• Do the import.

• Then close the Import dialog

• Open it back up

• Re-import and ensure the option is still working

Initially I tested enabling the option minimize cmd during the relog.
Imported logs twice, after closing the import window. It worked fine
Then I reverted it, that is, unchecked the option to minimize the cmd during relog, since I prefer to see the window. It also worked fine twice.

[hacitandogan]

Tested these changes and all looks fine.
Log capture time ;

Readtrace log capture time without local time adjustment;

With Local Server Time Option;

[asavioliMSFT]

QDS_ASYNC_QUEUE

I think we can. Paul Randal agrees

https://www.sqlskills.com/help/waits/qds_async_queue/