Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add logging for number of columns and rows when creating datasets, set useSingleDatasetMode=True by default, fix validation dataset handling #1222

Merged
merged 2 commits into from
Dec 1, 2021
Merged

fix: add logging for number of columns and rows when creating datasets, set useSingleDatasetMode=True by default, fix validation dataset handling #1222

merged 2 commits into from
Dec 1, 2021

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Oct 20, 2021 •
edited
Loading

  • add back some logging that was removed previously for tracking generated dataset size
  • set useSingleDatasetMode=True by default
  • fix issue with validation dataset failing in single dataset mode

@imatiach-msft imatiach-msft changed the title add logging for number of columns and rows when creating datasets, set useSingleDatasetMode=True by default fix: add logging for number of columns and rows when creating datasets, set useSingleDatasetMode=True by default Oct 20, 2021
@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2021 •
edited
Loading

Codecov Report

Merging #1222 (3164a32) into master (db03b01) will increase coverage by 0.11%.
The diff coverage is 84.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1222      +/-   ##
==========================================
+ Coverage   83.14%   83.26%   +0.11%     
==========================================
  Files         300      300              
  Lines       13709    13720      +11     
  Branches      656      670      +14     
==========================================
+ Hits        11399    11424      +25     
+ Misses       2310     2296      -14
Impacted Files Coverage Δ
...rosoft/azure/synapse/ml/lightgbm/SharedState.scala 88.46% <79.16%> (-0.43%) ⬇️
...zure/synapse/ml/lightgbm/TaskTrainingMethods.scala 100.00% <100.00%> (ø)
...ynapse/ml/lightgbm/dataset/DatasetAggregator.scala 95.52% <100.00%> (+8.21%) ⬆️
...re/synapse/ml/lightgbm/params/LightGBMParams.scala 84.46% <100.00%> (ø)
...crosoft/azure/synapse/ml/io/http/HTTPClients.scala 73.33% <0.00%> (-10.00%) ⬇️
.../execution/streaming/continuous/HTTPSourceV2.scala 92.80% <0.00%> (+0.71%) ⬆️
...osoft/azure/synapse/ml/core/utils/AsyncUtils.scala 70.00% <0.00%> (+5.00%) ⬆️
...oft/azure/synapse/ml/lightgbm/swig/SwigUtils.scala 97.22% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db03b01...3164a32. Read the comment docs.

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft imatiach-msft force-pushed the ilmat/add-logging branch 2 times, most recently from 8f207cb to 1841ec4 Compare November 17, 2021 06:52
@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft imatiach-msft force-pushed the ilmat/add-logging branch 2 times, most recently from 6692cce to f128d13 Compare November 17, 2021 15:34
@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft imatiach-msft changed the title fix: add logging for number of columns and rows when creating datasets, set useSingleDatasetMode=True by default fix: add logging for number of columns and rows when creating datasets, set useSingleDatasetMode=True by default, fix validation dataset handling Nov 17, 2021
@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

mhamilton723
mhamilton723 requested changes Nov 17, 2021
View reviewed changes
Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor Question

lightgbm/src/main/scala/com/microsoft/azure/synapse/ml/lightgbm/dataset/DatasetAggregator.scala Outdated Show resolved Hide resolved
@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit 82719fe into microsoft:master Dec 1, 2021
@stuartleeks stuartleeks mentioned this pull request Dec 6, 2021
Closed
@stuartleeks stuartleeks mentioned this pull request Dec 16, 2021
Closed
This was referenced Dec 27, 2021
Open
Open
@imatiach-msft imatiach-msft mentioned this pull request Jan 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhamilton723 mhamilton723 mhamilton723 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imatiach-msft @codecov-commenter @mhamilton723