Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Update bcrypt & node-sass #253

Closed
wants to merge 1 commit into from
Closed

Update bcrypt & node-sass #253

wants to merge 1 commit into from

Conversation

CarlosKlapp
Copy link
Contributor

@CarlosKlapp CarlosKlapp commented Dec 10, 2019 •
edited
Loading

Update bcrypt

Update node-sass

  • Update node-sass to enable it to compile on the Mac when using Node v13.2.0

Update README.md

  • Replace bcrypt-nodejs with bcrypt

@CarlosSolrac
Update bcrypt
5bec2b9 
* bcrypt-nodejs is no longer actively maintained https://www.npmjs.com/package/bcrypt-nodejs

Update node-sass
* Update node-sass to enable it to compile on the Mac when using Node v13.2.0

Update README.md
* Replace bcrypt-nodejs with bcrypt
@msftclas
Copy link

msftclas commented Dec 10, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@CarlosKlapp CarlosKlapp mentioned this pull request Dec 10, 2019
Open
@peterblazejewicz
Copy link
Collaborator

@CarlosKlapp
We have discussion about bcrypt migration here:
#245
Are concerns from #245 still valid?

Please create new PR that updates node-sass only, it will be accepted stright away as no brainer.
https://gist.github.com/mikepea/863f63d6e37281e329f8#keep-it-small

@peterblazejewicz peterblazejewicz mentioned this pull request May 10, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CarlosKlapp @msftclas @peterblazejewicz @CarlosSolrac