Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module: Twoslash not picking up types from node modules by default #962

Closed
orta opened this issue Aug 24, 2020 · 1 comment
Closed

Module: Twoslash not picking up types from node modules by default #962

orta opened this issue Aug 24, 2020 · 1 comment
Labels
Module An issue about one of our hosted npm modules Twoslash Issues related to the twoslash library for code samples

Comments

@orta
Copy link
Contributor

orta commented Aug 24, 2020

Improvement Idea: In https://github.com/ddprrt/ddprrt.github.io/pull/41/ I wanted to use the types for preact - which comes with the module, so I added it to node_modules but it wasn't picked up. It should be picked up.

Why: It's the most logical way to handle type acquisition in a twoslash code sample
@orta orta added Module An issue about one of our hosted npm modules Twoslash Issues related to the twoslash library for code samples labels Aug 24, 2020
@orta orta mentioned this issue Aug 24, 2020
Merged
@orta
Copy link
Contributor Author

orta commented Aug 25, 2020

This came in with 1.0

@orta orta closed this as completed Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Module An issue about one of our hosted npm modules Twoslash Issues related to the twoslash library for code samples
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orta