Skip to content

Don’t emit file references that are already referenced via imports #56614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2023
Merged

Don’t emit file references that are already referenced via imports #56614

merged 1 commit into from
Dec 12, 2023

Conversation

andrewbranch
Copy link
Member

Fixes:

Just an extra note that TS is adding:

/// <reference path="../../module/module.d.ts" />

even though there also exists a related type import, importing from the same file:

import type { ModuleOptions } from '../../module/module';

So in that case at least the reference looks redundant.

from #56571 (comment)

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 30, 2023
andrewbranch
andrewbranch commented Nov 30, 2023
View reviewed changes
src/compiler/transformers/declarations.ts

function mapReferencesIntoArray(references: FileReference[], outputFilePath: string): (file: SourceFile) => void {
return file => {
if (exportedModulesFromDeclarationEmit?.includes(file.symbol)) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what this array was for, and the name confuses me (these aren’t exported from this file, they’re imported 🤔), but it appears to be exactly what I was going to add, so I opted not to duplicate it.

@andrewbranch
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 30, 2023 •
edited
Loading

Heya @andrewbranch, I've started to run the regular perf test suite on this PR at 1f470e7. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@andrewbranch
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v18.15.0, x64)
Memory used 295,308k (± 0.01%) 295,314k (± 0.01%) ~ 295,294k 295,343k p=0.748 n=6
Parse Time 2.65s (± 0.19%) 2.65s (± 0.21%) ~ 2.64s 2.65s p=0.640 n=6
Bind Time 0.82s (± 0.50%) 0.82s (± 0.00%) ~ 0.82s 0.82s p=0.405 n=6
Check Time 8.08s (± 0.26%) 8.07s (± 0.23%) ~ 8.05s 8.10s p=0.466 n=6
Emit Time 7.08s (± 0.15%) 7.08s (± 0.24%) ~ 7.06s 7.10s p=0.934 n=6
Total Time 18.63s (± 0.08%) 18.62s (± 0.18%) ~ 18.58s 18.66s p=0.627 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used 193,143k (± 1.55%) 192,223k (± 1.27%) ~ 191,181k 197,200k p=1.000 n=6
Parse Time 1.35s (± 0.76%) 1.36s (± 0.86%) ~ 1.35s 1.38s p=0.241 n=6
Bind Time 0.72s (± 0.00%) 0.72s (± 0.57%) ~ 0.72s 0.73s p=0.405 n=6
Check Time 9.16s (± 0.55%) 9.22s (± 0.43%) ~ 9.17s 9.27s p=0.107 n=6
Emit Time 2.61s (± 0.34%) 2.62s (± 0.45%) ~ 2.60s 2.63s p=0.214 n=6
Total Time 13.84s (± 0.36%) 13.92s (± 0.27%) +0.07s (+ 0.54%) 13.88s 13.98s p=0.030 n=6
Monaco - node (v18.15.0, x64)
Memory used 347,348k (± 0.01%) 347,363k (± 0.01%) ~ 347,335k 347,399k p=0.377 n=6
Parse Time 2.46s (± 0.21%) 2.46s (± 0.26%) ~ 2.45s 2.47s p=0.386 n=6
Bind Time 0.92s (± 0.90%) 0.93s (± 0.44%) ~ 0.92s 0.93s p=0.285 n=6
Check Time 6.87s (± 0.44%) 6.88s (± 0.29%) ~ 6.84s 6.89s p=0.738 n=6
Emit Time 4.05s (± 0.19%) 4.04s (± 0.29%) ~ 4.03s 4.06s p=0.058 n=6
Total Time 14.30s (± 0.20%) 14.30s (± 0.16%) ~ 14.26s 14.32s p=0.871 n=6
TFS - node (v18.15.0, x64)
Memory used 302,622k (± 0.01%) 302,637k (± 0.01%) ~ 302,600k 302,685k p=0.575 n=6
Parse Time 2.01s (± 0.93%) 2.00s (± 0.69%) ~ 1.99s 2.02s p=0.935 n=6
Bind Time 1.00s (± 1.63%) 1.00s (± 0.52%) ~ 0.99s 1.00s p=0.284 n=6
Check Time 6.27s (± 0.53%) 6.31s (± 0.64%) ~ 6.26s 6.38s p=0.191 n=6
Emit Time 3.57s (± 0.55%) 3.57s (± 0.62%) ~ 3.54s 3.60s p=0.806 n=6
Total Time 12.86s (± 0.33%) 12.88s (± 0.27%) ~ 12.83s 12.93s p=0.466 n=6
material-ui - node (v18.15.0, x64)
Memory used 506,786k (± 0.00%) 506,795k (± 0.00%) ~ 506,773k 506,821k p=0.575 n=6
Parse Time 2.57s (± 0.32%) 2.58s (± 0.49%) ~ 2.57s 2.60s p=0.293 n=6
Bind Time 1.00s (± 1.17%) 0.99s (± 0.76%) ~ 0.98s 1.00s p=0.383 n=6
Check Time 16.81s (± 0.32%) 16.88s (± 0.37%) +0.07s (+ 0.43%) 16.76s 16.94s p=0.045 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 20.38s (± 0.29%) 20.45s (± 0.34%) ~ 20.32s 20.51s p=0.092 n=6
xstate - node (v18.15.0, x64)
Memory used 512,664k (± 0.01%) 512,715k (± 0.01%) ~ 512,675k 512,768k p=0.109 n=6
Parse Time 3.27s (± 0.33%) 3.27s (± 0.33%) ~ 3.25s 3.28s p=1.000 n=6
Bind Time 1.54s (± 0.53%) 1.54s (± 0.34%) ~ 1.53s 1.54s p=0.929 n=6
Check Time 2.79s (± 0.58%) 2.80s (± 1.00%) ~ 2.77s 2.85s p=0.515 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 4.99%) ~ 0.08s 0.09s p=0.405 n=6
Total Time 7.68s (± 0.15%) 7.69s (± 0.46%) ~ 7.64s 7.74s p=0.513 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • Monaco - node (v18.15.0, x64)
  • TFS - node (v18.15.0, x64)
  • material-ui - node (v18.15.0, x64)
  • xstate - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,330ms (± 0.97%) 2,345ms (± 0.77%) ~ 2,322ms 2,374ms p=0.378 n=6
Req 2 - geterr 5,417ms (± 1.53%) 5,400ms (± 1.39%) ~ 5,337ms 5,513ms p=0.575 n=6
Req 3 - references 324ms (± 1.26%) 323ms (± 1.15%) ~ 320ms 330ms p=0.139 n=6
Req 4 - navto 278ms (± 1.40%) 280ms (± 1.58%) ~ 273ms 287ms p=0.931 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 83ms (± 6.72%) 84ms (± 5.69%) ~ 81ms 91ms p=0.806 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,473ms (± 0.53%) 2,484ms (± 1.39%) ~ 2,430ms 2,529ms p=0.336 n=6
Req 2 - geterr 4,111ms (± 1.65%) 4,114ms (± 1.73%) ~ 4,058ms 4,206ms p=1.000 n=6
Req 3 - references 343ms (± 1.34%) 342ms (± 1.64%) ~ 334ms 346ms p=0.809 n=6
Req 4 - navto 285ms (± 0.47%) 285ms (± 0.47%) ~ 284ms 287ms p=0.805 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 88ms (± 5.14%) 86ms (± 7.70%) ~ 77ms 92ms p=0.571 n=6
xstateTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,596ms (± 0.49%) 2,604ms (± 0.89%) ~ 2,561ms 2,622ms p=0.297 n=6
Req 2 - geterr 1,691ms (± 2.04%) 1,694ms (± 1.61%) ~ 1,643ms 1,722ms p=0.810 n=6
Req 3 - references 116ms (± 9.25%) 116ms (± 8.77%) ~ 102ms 123ms p=0.867 n=6
Req 4 - navto 363ms (± 0.87%) 363ms (± 0.94%) ~ 357ms 367ms p=0.934 n=6
Req 5 - completionInfo count 2,073 (± 0.00%) 2,073 (± 0.00%) ~ 2,073 2,073 p=1.000 n=6
Req 5 - completionInfo 308ms (± 0.95%) 316ms (± 0.99%) +8ms (+ 2.43%) 310ms 319ms p=0.013 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstateTSServer - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v18.15.0, x64)
Execution time 152.65ms (± 0.20%) 152.59ms (± 0.19%) ~ 151.43ms 155.29ms p=0.128 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time 228.21ms (± 0.15%) 227.93ms (± 0.16%) -0.27ms (- 0.12%) 226.56ms 234.71ms p=0.000 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time 229.57ms (± 0.19%) 229.56ms (± 0.18%) ~ 227.92ms 232.42ms p=0.949 n=600
typescript-startup - node (v18.15.0, x64)
Execution time 229.31ms (± 0.21%) 229.21ms (± 0.19%) -0.10ms (- 0.04%) 227.69ms 236.14ms p=0.044 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@andrewbranch andrewbranch mentioned this pull request Dec 1, 2023
Closed
@andrewbranch andrewbranch merged commit 289344a into main Dec 12, 2023
@andrewbranch andrewbranch deleted the bug/56571 branch December 12, 2023 00:35
c0sta pushed a commit to c0sta/TypeScript that referenced this pull request Dec 20, 2023
@andrewbranch @c0sta
Don’t emit file references that are already referenced via imports (m…
5157062 
…icrosoft#56614)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@weswigham weswigham Awaiting requested review from weswigham

Assignees

@andrewbranch andrewbranch

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewbranch @typescript-bot @sheetalkamat