Merge master into release-2.1 #12440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix functions that were unused (getJsDocComments), redundant (append) or badly named (getJSDocCommentsFromText)
Yeah, that name is way too long.
1. Get rid of parent check. 2. Use a couple of nested functions, one of them a recursive worker.
And delete its near-duplicate which was much less correct. The callers that had to switch are slightly more complex and more correct now.
Cache only uses one property now. getJSDocs isn't generic and doesn't take a function parameter any more. The code is overall easier to read.
Codegen: Do not subtract 0 in arguments to rest array loop
…ame expression Fixes #12291
…ference inclusion if possible (#12341)
That is, without --noImplicitAny
…itted in .d.ts Fixes #12326
Higher order type relations for mapped types
…implicit-any Disable evolving types with implicit any
update to tslint@next
Fix issue #12260.
Minor fixes for 'keyof T' and indexed acces types
* add locale options to tsserver * make sys an argument * fix mistakes and address code review
Fix lint errors
getJSDocs cleanup
recompute character to column when comparing indentations
Make "exclude" default to empty if "include" is present.
Change 'keyof T' to always be string-like
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #12425
And changes to tslint, rwc as well.