Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution guidlines #26

Merged
merged 5 commits into from Jul 16, 2014
Merged

Add contribution guidlines #26

merged 5 commits into from Jul 16, 2014

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Jul 16, 2014

Add a new CONTRIBUTIONS.md to the root of the repo

@@ -0,0 +1,66 @@
## Contributing bug fixes
TypeScript is currently accepting contributions in the form of bug fixes. A bug must have an issue tracking it in the issue tracker that has been approved ("Milestone == Community") by the TypeScript team. Your pull request should include a link to the bug that you are fixing. If you�ve submitted a PR for a bug, please post a comment in the bug to avoid duplication of effort.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the smart quotes/apostrophes to the unsmart versions

@@ -0,0 +1,66 @@
## Contributing bug fixes
TypeScript is currently accepting contributions in the form of bug fixes. A bug must have an issue tracking it in the issue tracker that has been approved ("Milestone == Community") by the TypeScript team. Your pull request should include a link to the bug that you are fixing. If you�ve submitted a PR for a bug, please post a comment in the bug to avoid duplication of effort.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a � in the contractions here and elsewhere in the file

TypeScript is currently accepting contributions in the form of bug fixes. A bug must have an issue tracking it in the issue tracker that has been approved ("Milestone == Community") by the TypeScript team. Your pull request should include a link to the bug that you are fixing. If you've submitted a PR for a bug, please post a comment in the bug to avoid duplication of effort.

## Contributing features
Features (things that add new or improved functionality to TypeScript) may be accepted, but will need to first be approved (marked as "Milestone == Community" by a TypeScript coordinator with the message "Approved") in the suggestion issue. Please include [feature] in the title of your forum post. Features with language design impact, or that are adequately satisfied with external tools, will not be accepted.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says "forum post".

mhegazy added a commit that referenced this pull request Jul 16, 2014
@mhegazy mhegazy merged commit 6ee5f81 into master Jul 16, 2014
@mhegazy mhegazy deleted the contributions branch July 16, 2014 19:04
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants