Fix references to path-mapped ambient modules in declaration files #32878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
commented
Aug 13, 2019
|
|
||
| //// [index.d.ts] | ||
| /// <reference types="@ts-bug/a" /> | ||
| export declare function b(text: string): import("@ts-bug/a").AText; |
There was a problem hiding this comment.
As an aside, since the import is import("@ts-bug/a"), we don't need the /// <reference types="@ts-bug/a" />, since they refer to the "same" thing (or at least cause the same file to be found and included). However since the import could be something like @ts-bug/a/b (which could be an ambient module in @ts-bug/a), we can't generally elide the reference. A cleanup pass where we remove types directives which exactly match an import somewhere in the file may be pertinent.
andrewbranch
approved these changes
Aug 13, 2019
|
@RyanCavanaugh @DanielRosenwasser wanna have this ported this to 3.6 (since it was in the 3.6 milestone)? |
|
@typescript-bot cherry-pick this into release-3.6 |
|
Hey @weswigham, I've opened #32881 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Aug 13, 2019
DanielRosenwasser
added a commit
that referenced
this pull request
Aug 13, 2019
🤖 Cherry-pick PR #32878 into release-3.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26863
With this change, we now attempt to use a non-relative reference to a declaration file, if possible, before emitting a relative reference.