Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not list output files that just change their modified time when using --listEmittedFiles #35714

Merged
merged 2 commits into from
Dec 18, 2019

Conversation

sheetalkamat
Copy link
Member

Fixes #35605

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By reading the linked issue, this makes sense, but I don’t know how to reason about these baselines. How do I look at the test and look at the baseline and determine whether the intended effect is represented there?

@@ -358,18 +358,33 @@ export class cNew {}`);
});
});

const coreChanges: TscIncremental[] = [
{
buildKind: BuildKind.IncrementalDtsChange,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the change that's made on top of sample (from tests/projects/sample1) and the baseline goes into incremental-declaration-changes/scenario name. The baseline contains output on the command line and the changes in file system

@@ -0,0 +1,209 @@
//// [/lib/incremental-declaration-changesOutput.txt]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the output from running the below command when the change is made.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are there other filenames that are not being printed because only their timestamp changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

exports.someClass = someClass;


//// [/src/core/index.ts]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file represents the change.. Others are output files written

@@ -0,0 +1,211 @@
//// [/lib/incremental-declaration-changesOutput.txt]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is after making change that doesnt change the d.ts file from core

exports.someClass = someClass;


//// [/src/core/index.ts]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the change that was made.

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation! 👍

@sheetalkamat sheetalkamat changed the base branch from baselineTscWatch to master December 18, 2019 18:24
@sheetalkamat sheetalkamat merged commit 8535076 into master Dec 18, 2019
@sheetalkamat sheetalkamat deleted the modifiedTimeNotEmittedFiles branch December 18, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build not emitting files, but listing them
2 participants