Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build not emitting files, but listing them #35605

Closed
TimVosch opened this issue Dec 10, 2019 · 3 comments · Fixed by #35714
Closed

Build not emitting files, but listing them #35605

TimVosch opened this issue Dec 10, 2019 · 3 comments · Fixed by #35714
Assignees
@sheetalkamat
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Milestone
TypeScript 3.8.0

Comments

@TimVosch
Copy link

TypeScript Version: 3.7.x-dev.201xxxxx

Search Terms:
build out
no files build
emitted files
list emitted files incorrect

Expected behavior:

  1. Expect tsc --build to compile files after outDir is deleted.
  2. And expect tsc --build --listEmittedFiles to list files emitted

Actual behavior:
Steps to replicate:

  1. Compile a composite project with yarn tsc -b
  2. Remove outDir (dist or lib for example)
  3. Recompile with yarn tsc -b (optionally with --listEmittedFiles)
    4.a. Observe no new compiled files
    4.b. Observe --listEmittedFiles listing files that aren't actually emitted.

See demo repo:
https://github.com/TimVosch/TS-Build-Bug

Related Issues:
Unfortunately no.
@TimVosch
Copy link
Author

TimVosch commented Dec 10, 2019 •
edited
Loading

Also removing tsconfig.tsbuildinfo solves the issue. However compiling with -v verbose, does acknowledge that the outDir is outdated and should be rebuild.

edit:
I use tsc -b --clean. However having verbose and listEmittedFiles being contradictory to what actually happens is confusing.

@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Dec 10, 2019
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 3.8.0 milestone Dec 10, 2019
@RyanCavanaugh
Copy link
Member

Seems to be a regression

@sheetalkamat
Copy link
Member

So not generating new build is intended behavior, refer to #30602
To make matters clear, if we change the modified time for the files, it should not mark them as emitted files.

sheetalkamat added a commit that referenced this issue Dec 16, 2019
@sheetalkamat
Do not list output file that just changes modified time stamp as emit…
3de934a 
…ted file

Fixes #35605
@sheetalkamat sheetalkamat mentioned this issue Dec 16, 2019
Merged
@sheetalkamat sheetalkamat added the Fix Available A PR has been opened for this issue label Dec 16, 2019
sheetalkamat added a commit that referenced this issue Dec 18, 2019
@sheetalkamat
Do not list output files that just change their modified time when us…
8535076 
…ing --listEmittedFiles (#35714)

* Baseline incremental scenarios for listEmittedFiles

* Do not list output file that just changes modified time stamp as emitted file
Fixes #35605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sheetalkamat sheetalkamat

Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Projects
None yet
Milestone
TypeScript 3.8.0
3 participants
@TimVosch @RyanCavanaugh @sheetalkamat