Harden telemetryOnOpenFile #36993
Merged
Harden telemetryOnOpenFile #36993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanCavanaugh
requested review from
amcasey and
sandersn
and removed request for
amcasey
sheetalkamat
approved these changes
Feb 25, 2020
|
I couldn't find an event handler that actually consumes that event - the default one doesn't and I'm pretty sure that's what VS uses. VS also doesn't act on events with that name. |
amcasey
approved these changes
Feb 25, 2020
|
@typescript-bot cherry-pick this to release-3.8 |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Feb 25, 2020
Component commits: 7721570 Harden telemetryOnOpenFile 9535e7b Merge branch 'master' of https://github.com/RyanCavanaugh/TypeScript into fix36984
|
Hey @RyanCavanaugh, I've opened #37020 for you. |
RyanCavanaugh
added a commit
that referenced
this pull request
Feb 25, 2020
Component commits: 7721570 Harden telemetryOnOpenFile 9535e7b Merge branch 'master' of https://github.com/RyanCavanaugh/TypeScript into fix36984 Co-authored-by: Ryan Cavanaugh <RyanCavanaugh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36984, which we don't have a repro for but the root cause is straightforward enough