Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix easy misunderstanding "! ===" #37838

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Fix easy misunderstanding "! ===" #37838

merged 2 commits into from
Apr 8, 2020

Conversation

zhangciwu
Copy link
Contributor

Fixes #37837

Some Non-null assertion operators are just unnecessary,
And wrap another one inside parentheses,
To eliminate misunderstandings of ! === with !==

@msftclas
Copy link

msftclas commented Apr 8, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@zhangciwu zhangciwu changed the title Fix easy misunderstanding Fix easy misunderstanding "! ===" Apr 8, 2020
@sandersn sandersn added the Housekeeping Housekeeping PRs label Apr 8, 2020
@sandersn sandersn self-assigned this Apr 8, 2020
@sandersn sandersn merged commit 126c6ab into microsoft:master Apr 8, 2020
@sandersn
Copy link
Member

sandersn commented Apr 8, 2020

Thanks for improving our code quality @zhangciwu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees

@sandersn sandersn

Labels
Housekeeping Housekeeping PRs
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Easy misunderstanding: "! ==="
3 participants
@zhangciwu @msftclas @sandersn