Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra newline in class member snippet completions #46737

Merged
merged 3 commits into from Nov 9, 2021
Merged

Conversation

@gabritto
Copy link
Member

@gabritto gabritto commented Nov 8, 2021

Fixes #46609.

For now there will always be trailing semicolons at the end of property or signature declarations, but I'm working on fixing that in another PR.

@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Nov 9, 2021

@typescript-bot cherry-pick this to release-4.5

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Nov 9, 2021

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.5 on this PR at 67d631c. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Nov 9, 2021

Hey @andrewbranch, I've opened #46742 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this issue Nov 9, 2021
Component commits:
74cd7a5 fix extra newline

8df5bef Merge branch 'main' into gabritto/issue46609

67d631c fix test
@gabritto gabritto merged commit e5a6ae3 into main Nov 9, 2021
11 checks passed
@gabritto gabritto deleted the gabritto/issue46609 branch Nov 9, 2021
andrewbranch pushed a commit that referenced this issue Nov 9, 2021
Component commits:
74cd7a5 fix extra newline

8df5bef Merge branch 'main' into gabritto/issue46609

67d631c fix test

Co-authored-by: Gabriela Araujo Britto <gabrielaa@microsoft.com>
mprobst added a commit to mprobst/TypeScript that referenced this issue Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants