make Array explicitly extend ReadonlyArray and use this type in the callbacks
#46781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like you've sent a pull request to update our 'lib' files. These files aren't meant to be edited by hand, as they consist of last-known good states of the compiler and are generated from 'src'. Unless this is necessary, consider closing the pull request and sending a separate PR to update 'src'. |
|
The TypeScript team hasn't accepted the linked issue #46394. If you can get it accepted, this PR will have a better chance of being reviewed. |
typescript-bot
added
the
For Uncommitted Bug
DetachHead
force-pushed
the
main
branch
2 times, most recently
from
6be1262
to
f009cf6
Compare
|
i don't think the bot noticed but i've removed the changes to the top level |
andrewbranch
added
the
Experiment
|
Quite a lot of failing tests already 😅 |
DetachHead
force-pushed
the
main
branch
2 times, most recently
from
dea9f3e
to
f9d062d
Compare
|
@andrewbranch should be good now |
|
I get why it’s happening and I guess it technically makes sense, but I feel like the baseline changes look kind of confusing and undesirable. |
|
Just out of curiosity @typescript-bot perf test this |
|
Heya @andrewbranch, I've started to run the parallelized Definitely Typed test suite on this PR at f9d062d. You can monitor the build here. |
|
Heya @andrewbranch, I've started to run the inline community code test suite on this PR at f9d062d. You can monitor the build here. Update: The results are in! |
|
Heya @andrewbranch, I've started to run the perf test suite on this PR at f9d062d. You can monitor the build here. Update: The results are in! |
|
@andrewbranch Here they are:Comparison Report - main..refs/pull/46781/merge [adonis-framework]1 of 1 projects failed to build with the old tsc /mnt/ts_downloads/adonis-framework/tsconfig.json
[bcryptjs]1 of 1 projects failed to build with the old tsc /mnt/ts_downloads/bcryptjs/tsconfig.json
[lodash]1 of 1 projects failed to build with the old tsc /mnt/ts_downloads/lodash/tsconfig.json
|
|
@andrewbranch Here they are:Comparison Report - main..46781
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
i think i know how to fix the downstream errors, will give it a go |
|
will the bot listen to me? @typescript-bot perf test this |
|
@typescript-bot perf test this |
|
Heya @andrewbranch, I've started to run the inline community code test suite on this PR at acdb72d. You can monitor the build here. Update: The results are in! |
|
Heya @andrewbranch, I've started to run the parallelized Definitely Typed test suite on this PR at acdb72d. You can monitor the build here. |
|
Heya @andrewbranch, I've started to run the perf test suite on this PR at acdb72d. You can monitor the build here. Update: The results are in! |
|
@andrewbranch Here they are:Comparison Report - main..refs/pull/46781/merge [adonis-framework]1 of 1 projects failed to build with the old tsc /mnt/ts_downloads/adonis-framework/tsconfig.json
[bcryptjs]1 of 1 projects failed to build with the old tsc /mnt/ts_downloads/bcryptjs/tsconfig.json
[lodash]1 of 1 projects failed to build with the old tsc /mnt/ts_downloads/lodash/tsconfig.json
|
|
@andrewbranch Here they are:Comparison Report - main..46781
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
so i fixed it by using the i'll make a PR to definitelytyped with this change later today and link it here |
|
My biggest concern right now is that it might be confusing to some users for the quick info / errors for every common Array method to reference |
|
i personally don't think that's an issue. most other languages have a base "collection" or "iterable" interface that mutable arrays extend. i'd argue that it's far more confusing now than it would be after this change. currently it's difficult to even tell if currently the only way to find out is by attempting to use an however if you think the name interface BaseArray<T> {
map<U>(callbackfn: (value: T, index: number, array: this) => U, thisArg?: any): U[];
filter<S extends T>(predicate: (value: T, index: number, array: this) => value is S, thisArg?: any): S[];
//...
}
export interface ReadonlyArray<T> extends BaseArray<T> {
//nothing to see here
}
export interface Array<T> extends ReadonlyArray<T> {
push(...items: T[]): number;
//...
} |
10 tasks
DetachHead
changed the title
Array explicitly extend ReadonlyArrayArray explicitly extend ReadonlyArray and use this type in the callbacks
|
@DanielRosenwasser i ran the same command mentioned in that PR with and without my change, and as far as i can tell there doesn't seem to be much of a difference: before: after: (disclaimer: my PC is not good and it was difficult to get consistent results) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46394