Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try and prevent getIgnoreDeprecationsVersion from holding onto everything in createProgram #58361

Closed
wants to merge 1 commit into from

Conversation

jakebailey
Copy link
Member

In #58274 I'm seeing a truly confusing chain of retainers.

image

Try and redo this so that there's no way that anything's being closed over.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 29, 2024
@jakebailey
Copy link
Member Author

@typescript-bot pack this

1 similar comment
@jakebailey
Copy link
Member Author

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 29, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
pack this ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 29, 2024

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161544/artifacts?artifactName=tgz&fileId=6399472EA6D1C04EBB274FFF53DDD0518C7B0E0CFA5F0B2946AA20F0923BB53F02&fileName=/typescript-5.5.0-insiders.20240429.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-58361-3".;

@jakebailey jakebailey closed this May 30, 2024
@jakebailey jakebailey deleted the deprecation-closure branch May 30, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants