Mark file as skips typechecking if it contains ts-nocheck #58593

sheetalkamat · 2024-05-20T19:10:26Z

This is different take on #58592 to skip checking only if no-checkJs
Frankly i dont know what all will fail because we dont have enough coverage for js + incremental as such from this perspective.

cc: @weswigham

From investigating #56956

Needs #58364 to work correctly for js emit

src/compiler/checker.ts

sheetalkamat · 2024-05-20T22:58:44Z

@typescript-bot test it

typescript-bot · 2024-05-20T22:58:47Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-05-20T23:16:33Z

Hey @sheetalkamat, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-05-20T23:17:39Z

@sheetalkamat Here are the results of running the user tests comparing main and refs/pull/58593/merge:

Everything looks good!

typescript-bot · 2024-05-20T23:34:59Z

@sheetalkamat
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,248	_50,248	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,814k (± 0.76%)}	_{192,872k (± 0.83%)}	_~	_192,173k	_196,126k	_{p=0.575 n=6}
_{Parse Time}	_{1.29s (± 1.99%)}	_{1.29s (± 1.45%)}	_~	_1.27s	_1.31s	_{p=0.677 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.53s (± 0.29%)}	_{9.55s (± 0.31%)}	_~	_9.50s	_9.59s	_{p=0.226 n=6}
_{Emit Time}	_{2.65s (± 0.56%)}	_{2.66s (± 0.50%)}	_~	_2.64s	_2.68s	_{p=0.285 n=6}
_{Total Time}	_{14.19s (± 0.27%)}	_{14.21s (± 0.36%)}	_~	_14.12s	_14.25s	_{p=0.226 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,110	_944,110	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,140	_407,140	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,119k (± 0.00%)}	_{1,222,101k (± 0.00%)}	_~	_1,222,067k	_1,222,176k	_{p=0.689 n=6}
_{Parse Time}	_{6.79s (± 0.68%)}	_{6.79s (± 0.55%)}	_~	_6.76s	_6.85s	_{p=0.518 n=6}
_{Bind Time}	_{1.87s (± 0.44%)}	_{1.88s (± 0.45%)}	_~	_1.86s	_1.88s	_{p=0.718 n=6}
_{Check Time}	_{31.34s (± 0.11%)}	_{31.25s (± 0.74%)}	_~	_30.99s	_31.67s	_{p=0.128 n=6}
_{Emit Time}	_{14.72s (± 0.54%)}	_{14.81s (± 0.55%)}	_~	_14.69s	_14.92s	_{p=0.126 n=6}
_{Total Time}	_{54.72s (± 0.20%)}	_{54.73s (± 0.52%)}	_~	_54.39s	_55.17s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,979,156	_1,979,156	_~	_~	_~	_{p=1.000 n=6}
_Types	_882,049	_882,049	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,884,994k (± 0.00%)}	_{1,884,986k (± 0.00%)}	_~	_1,884,947k	_1,885,011k	_{p=1.000 n=6}
_{Parse Time}	_{6.79s (± 0.40%)}	_{6.78s (± 0.42%)}	_~	_6.75s	_6.81s	_{p=0.684 n=6}
_{Bind Time}	_{2.30s (± 1.37%)}	_{2.28s (± 0.39%)}	_~	_2.27s	_2.29s	_{p=0.270 n=6}
_{Check Time}	_{60.37s (± 0.35%)}	_{60.25s (± 0.33%)}	_~	_60.00s	_60.59s	_{p=0.423 n=6}
_{Emit Time}	_{0.14s (± 3.60%)}	_0.14s	_~	_~	_~	_{p=0.174 n=6}
_{Total Time}	_{69.59s (± 0.32%)}	_{69.46s (± 0.29%)}	_~	_69.17s	_69.77s	_{p=0.335 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,222,772	_1,222,830	_{+58 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,022	_260,027	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,338,777k (± 0.03%)}	_{2,339,212k (± 0.03%)}	_~	_2,338,485k	_2,340,165k	_{p=0.173 n=6}
_{Parse Time}	_{5.01s (± 1.04%)}	_{5.05s (± 1.04%)}	_~	_4.97s	_5.11s	_{p=0.173 n=6}
_{Bind Time}	_{1.89s (± 0.88%)}	_{1.89s (± 1.23%)}	_~	_1.87s	_1.93s	_{p=0.933 n=6}
_{Check Time}	_{33.81s (± 0.35%)}	_{33.77s (± 0.40%)}	_~	_33.52s	_33.92s	_{p=0.689 n=6}
_{Emit Time}	_{2.68s (± 2.13%)}	_{2.68s (± 2.36%)}	_~	_2.57s	_2.74s	_{p=0.936 n=6}
_{Total Time}	_{43.40s (± 0.18%)}	_{43.40s (± 0.44%)}	_~	_43.02s	_43.55s	_{p=0.378 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,222,772	_1,222,830	_{+58 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,022	_260,027	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,414,215k (± 0.05%)}	_{2,415,044k (± 0.04%)}	_~	_2,413,802k	_2,416,158k	_{p=0.230 n=6}
_{Parse Time}	_{6.35s (± 1.12%)}	_{6.28s (± 0.80%)}	_~	_6.21s	_6.35s	_{p=0.173 n=6}
_{Bind Time}	_{2.03s (± 0.88%)}	_{2.04s (± 1.76%)}	_~	_2.00s	_2.10s	_{p=0.518 n=6}
_{Check Time}	_{40.22s (± 0.14%)}	_{40.31s (± 0.31%)}	_~	_40.10s	_40.45s	_{p=0.109 n=6}
_{Emit Time}	_{3.30s (± 4.38%)}	_{3.19s (± 2.73%)}	_~	_3.08s	_3.27s	_{p=0.229 n=6}
_{Total Time}	_{51.92s (± 0.32%)}	_{51.82s (± 0.13%)}	_~	_51.71s	_51.90s	_{p=0.471 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_257,595	_257,609	_{+14 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,862	_104,867	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{426,544k (± 0.01%)}	_{426,537k (± 0.01%)}	_~	_426,483k	_426,620k	_{p=0.689 n=6}
_{Parse Time}	_{4.17s (± 0.62%)}	_{4.17s (± 0.25%)}	_~	_4.15s	_4.18s	_{p=0.357 n=6}
_{Bind Time}	_{1.62s (± 0.78%)}	_{1.63s (± 0.51%)}	_~	_1.63s	_1.65s	_{p=0.065 n=6}
_{Check Time}	_{22.15s (± 0.24%)}	_{22.20s (± 0.18%)}	_~	_22.13s	_22.24s	_{p=0.078 n=6}
_{Emit Time}	_{1.72s (± 1.89%)}	_{1.72s (± 1.24%)}	_~	_1.69s	_1.75s	_{p=0.746 n=6}
_{Total Time}	_{29.67s (± 0.20%)}	_{29.72s (± 0.11%)}	_~	_29.68s	_29.77s	_{p=0.147 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,575	_224,575	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,785	_93,785	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,858k (± 0.03%)}	_{369,863k (± 0.02%)}	_~	_369,749k	_369,962k	_{p=0.936 n=6}
_{Parse Time}	_{2.83s (± 0.88%)}	_{2.84s (± 1.27%)}	_~	_2.80s	_2.88s	_{p=0.687 n=6}
_{Bind Time}	_{1.58s (± 1.11%)}	_{1.58s (± 0.48%)}	_~	_1.57s	_1.59s	_{p=0.397 n=6}
_{Check Time}	_{15.67s (± 0.47%)}	_{15.67s (± 0.37%)}	_~	_15.55s	_15.70s	_{p=0.808 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.07s (± 0.45%)}	_{20.09s (± 0.42%)}	_~	_19.93s	_20.17s	_{p=0.630 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,825,740	_2,825,449	_{-291 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_958,540	_958,519	_{-21 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,999,944k (± 0.00%)}	_{3,000,038k (± 0.00%)}	_~	_2,999,888k	_3,000,151k	_{p=0.093 n=6}
_{Parse Time}	_{13.82s (± 0.23%)}	_{13.82s (± 0.20%)}	_~	_13.77s	_13.84s	_{p=1.000 n=6}
_{Bind Time}	_{4.14s (± 0.20%)}	_{4.21s (± 2.83%)}	_~	_4.12s	_4.37s	_{p=0.867 n=6}
_{Check Time}	_{73.53s (± 0.28%)}	_{73.54s (± 0.42%)}	_~	_73.22s	_73.96s	_{p=1.000 n=6}
_{Emit Time}	_{23.51s (± 0.81%)}	_{23.64s (± 0.84%)}	_~	_23.40s	_23.91s	_{p=0.378 n=6}
_{Total Time}	_{115.01s (± 0.25%)}	_{115.21s (± 0.14%)}	_~	_115.00s	_115.41s	_{p=0.149 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,866	_265,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,401	_108,401	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,663k (± 0.02%)}	_{410,647k (± 0.02%)}	_~	_410,563k	_410,785k	_{p=0.872 n=6}
_{Parse Time}	_{4.77s (± 1.01%)}	_{4.75s (± 0.86%)}	_~	_4.68s	_4.79s	_{p=0.520 n=6}
_{Bind Time}	_{2.07s (± 0.43%)}	_{2.08s (± 0.95%)}	_~	_2.04s	_2.10s	_{p=0.198 n=6}
_{Check Time}	_{21.05s (± 0.35%)}	_{20.99s (± 0.40%)}	_~	_20.85s	_21.08s	_{p=0.261 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.89s (± 0.26%)}	_{27.82s (± 0.42%)}	_~	_27.61s	_27.94s	_{p=0.335 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,654	_524,654	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,920	_178,920	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,666k (± 0.02%)}	_{462,740k (± 0.02%)}	_~	_462,647k	_462,916k	_{p=0.128 n=6}
_{Parse Time}	_{3.89s (± 0.25%)}	_{3.89s (± 0.51%)}	_~	_3.86s	_3.91s	_{p=1.000 n=6}
_{Bind Time}	_{1.45s (± 1.29%)}	_{1.44s (± 0.68%)}	_~	_1.43s	_1.45s	_{p=0.673 n=6}
_{Check Time}	_{22.48s (± 0.80%)}	_{22.56s (± 0.50%)}	_~	_22.37s	_22.68s	_{p=0.422 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.81s (± 0.63%)}	_{27.89s (± 0.40%)}	_~	_27.71s	_27.99s	_{p=0.471 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-05-21T00:43:14Z

@sheetalkamat Here are the results of running the top 400 repos comparing main and refs/pull/58593/merge:

Everything looks good!

sheetalkamat · 2024-05-21T19:46:57Z

Does this need to wait for #58364 given the ts-nocheck files may be emitting js?

weswigham · 2024-05-21T22:36:09Z

Does this need to wait for #58364 given the ts-nocheck files may be emitting js?

Either that or, like the other PR, only enabled when only .d.ts emit is performed by the checker in question.

sheetalkamat · 2024-05-22T16:34:11Z

Either that or, like the other PR, only enabled when only .d.ts emit is performed by the checker in question.

Thats tough I think and not work flowing information temporarily till we get the PR in so i will just wait for that PR to merge.

jakebailey · 2024-05-30T23:19:32Z

#58364 is in, so is this safe to update and get in?

weswigham · 2024-05-30T23:24:41Z

Yeah, just remember the condition in calculateNodeCheckFlagWorker in checker.ts and emitJsFileOrBundle in emitter.ts needs to swap from just compilerOptions.noCheck to something that can handle this, too. (probably just the skipTypeChecking util function this edits, unless you wanna do the piecemeal thing emitDeclarationFileOrBundle does - but that should probably just swap to skipTypeChecking, too)

sheetalkamat · 2024-05-31T00:14:50Z

@weswigham pls review again. I have merged with main and added those checks

Also i used canIncludeBind* function instead of skipsTypeChecking to avoid having to do extra checks (or get sourceFile if not needed)

src/compiler/checker.ts

src/compiler/emitter.ts

src/compiler/utilities.ts

sheetalkamat · 2024-05-31T18:27:53Z

@weswigham pls review so i can get this in for 5.5

* upstream/main: (37 commits) Added NoTruncation flag to completions (microsoft#58719) Clone node to remove location even when it has been modified if needed (microsoft#58706) Properly account for `this` argument in intersection apparent type caching (microsoft#58677) Fix: Include Values of Script Extensions for Unicode Property Value Expressions in Regular Expressions (microsoft#58615) In `reScanSlashToken` use `charCodeChecked` not `codePointChecked` (microsoft#58727) Shorten error spans for errors reported on constructor declarations (microsoft#58061) Mark file as skips typechecking if it contains ts-nocheck (microsoft#58593) Fixed an issue with broken `await using` declarations in `for of` loops (microsoft#56466) Do not expand type references in keyof and index access (microsoft#58715) Improve the performance of isolatedDeclarations quickfix (microsoft#58722) Unwrap `NoInfer` types when narrowing (microsoft#58292) Recover from type reuse errors by falling back to inferred type printing (microsoft#58720) Fixing self import (microsoft#58718) Enable JS emit for noCheck and noCheck for transpileModule (microsoft#58364) Revert PR 55371 (microsoft#58702) Update dependencies (microsoft#58639) Fix baselines after PR 58621 (microsoft#58705) Do not infer `yield*` type from contextual `TReturn` (microsoft#58621) `await using` normative changes (microsoft#58624) Handling statements from a known source file (microsoft#58679) ...

Skip typechecking before declaration file on js files with nocheck

700c5b3

typescript-bot assigned sheetalkamat May 20, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 20, 2024

sheetalkamat changed the title ~~Skip typechecking before declaration file on js files with nocheck~~ [Experiment] Skip typechecking before declaration file on js files with nocheck May 20, 2024

weswigham reviewed May 20, 2024

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

sheetalkamat force-pushed the skipCheckIfNoJSCheck branch 2 times, most recently from f3189ed to 989d088 Compare May 20, 2024 22:55

Try adding ts-noCheck checks to skipTypeChecking

ca1ff15

sheetalkamat force-pushed the skipCheckIfNoJSCheck branch from 989d088 to ca1ff15 Compare May 20, 2024 22:57

Make internal

52326d5

jakebailey mentioned this pull request May 21, 2024

Skip typechecking file when generating declaraiton to get d.ts signature for incremental build #58592

Merged

sheetalkamat changed the title ~~[Experiment] Skip typechecking before declaration file on js files with nocheck~~ Skip typechecking for files with no check in them even with dts emit May 21, 2024

sheetalkamat marked this pull request as ready for review May 21, 2024 02:24

sheetalkamat requested review from weswigham, andrewbranch and jakebailey May 21, 2024 02:56

sheetalkamat changed the title ~~Skip typechecking for files with no check in them even with dts emit~~ Mark file as skips typechecking if it contains ts-nocheck May 21, 2024

Merge branch 'main' into skipCheckIfNoJSCheck

f7dccc0

sheetalkamat added 2 commits May 30, 2024 17:01

Merge branch 'main' into skipCheckIfNoJSCheck

661d4fd

Handle noCheck for js Emit

3d2a9fe

weswigham requested changes May 31, 2024

View reviewed changes

src/compiler/checker.ts Show resolved Hide resolved

src/compiler/emitter.ts Show resolved Hide resolved

src/compiler/utilities.ts Show resolved Hide resolved

Fix incorrect check

3daa7c7

weswigham approved these changes May 31, 2024

View reviewed changes

sheetalkamat merged commit 40583ff into main May 31, 2024
28 checks passed

sheetalkamat deleted the skipCheckIfNoJSCheck branch May 31, 2024 19:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark file as skips typechecking if it contains ts-nocheck #58593

Mark file as skips typechecking if it contains ts-nocheck #58593

sheetalkamat commented May 20, 2024 •

edited

Loading

sheetalkamat commented May 20, 2024

typescript-bot commented May 20, 2024 •

edited

Loading

typescript-bot commented May 20, 2024

typescript-bot commented May 20, 2024

typescript-bot commented May 20, 2024

tsc

typescript-bot commented May 21, 2024

sheetalkamat commented May 21, 2024

weswigham commented May 21, 2024

sheetalkamat commented May 22, 2024

jakebailey commented May 30, 2024

weswigham commented May 30, 2024

sheetalkamat commented May 31, 2024 •

edited

Loading

sheetalkamat commented May 31, 2024

Mark file as skips typechecking if it contains ts-nocheck #58593

Mark file as skips typechecking if it contains ts-nocheck #58593

Conversation

sheetalkamat commented May 20, 2024 • edited Loading

sheetalkamat commented May 20, 2024

typescript-bot commented May 20, 2024 • edited Loading

typescript-bot commented May 20, 2024

typescript-bot commented May 20, 2024

typescript-bot commented May 20, 2024

tsc

typescript-bot commented May 21, 2024

sheetalkamat commented May 21, 2024

weswigham commented May 21, 2024

sheetalkamat commented May 22, 2024

jakebailey commented May 30, 2024

weswigham commented May 30, 2024

sheetalkamat commented May 31, 2024 • edited Loading

sheetalkamat commented May 31, 2024

sheetalkamat commented May 20, 2024 •

edited

Loading

typescript-bot commented May 20, 2024 •

edited

Loading

sheetalkamat commented May 31, 2024 •

edited

Loading